Re: [hypermail] [PATCH]: mkdir failures

 wknox_at_mitre.org (William R. Knox) writes:
> if (stat(dir, &sbuf)) {
> if (errno != ENOENT || mkdir(dir, set_dirmode) < 0) {
>- sprintf(errmsg, "%s \"%s\".",
>- lang[MSG_CANNOT_CREATE_DIRECTORY], dir);
>- progerr(errmsg);
>+ if (errno != EEXIST) {
>+ sprintf(errmsg, "%s \"%s\".",
>+ lang[MSG_CANNOT_CREATE_DIRECTORY],
>dir);
>+ progerr(errmsg);
>+ }
> return;
> }
> else if (set_showprogress)

 Thank you for tracking down this apparent problem. I've applied your patch, with a few changes. I removed the "return" stmts, which used to be merely pointless, but became potentially harmful now that it doesn't always terminate via progerr. I also removed the last "else".

-- 
------------------------------------------------------------------------------
Peter McCluskey          | Free Jon Johansen!
http://www.rahul.net/pcm |