Re: [hypermail] anchors don't have leading zero

I checked that the bug was introduced in 2.1.6. 2.1.5 was still ok. The pathc I sent really reurns the situation to the original code.

On Tue, 28 Jan 2003 11:16:40 +0200, Zvi Har'El wrote about "Re: [hypermail] anchors don't have leading zero":
> I identified the culprit, in threadprint.c . The patch is:
>
>
> --- src/threadprint.c.orig 2003-01-24 22:20:49.000000000 +0200
> +++ src/threadprint.c 2003-01-28 11:10:32.000000000 +0200
> _at_@ -252,8 +252,8 @@
> }
> else {
> fprintf(fp, "<li>%s<strong>%s</strong></a> "
> - "<a name=\"%s\"><em>%s <small>(%s)</small></em></a>\n", href,
> - subj, message_name (email), email->name, getdatestr(email->date));
> + "<a name=\"%d\"><em>%s <small>(%s)</small></em></a>\n", href,
> + subj, email->msgnum, email->name, getdatestr(email->date));
> }
> free(subj);
> ++num_replies[level];
>
>
> The problem is that message_name (email) already has the leading zeros, which
> are not needed. I check this, and it works. I also added the link with
> hypermail version ;-)
>
> On Tue, 28 Jan 2003 09:39:54 +0200, Zvi Har'El wrote about "Re: [hypermail] anchors don't have leading zero":
> > You can look at the archive in http://JV.Gilead.org.il/forum/ . In the message
> > file http://JV.Gilead.org.il/forum/2003/01/0050.html,
> > you see the lines
> >
> > <li><strong>Messages sorted by:</strong>
> > <a href="date.html#50">[ date ]</a>
> > <a href="index.html#50">[ thread ]</a>
> > <a href="subject.html#50">[ subject ]</a>
> > <a href="author.html#50">[ author ]</a>
> > <a href="attachment.html">[ attachment ]</a>
> > </ul>
> >
> > and in the thread index file http://JV.Gilead.org.il/forum/2003/01/index.html
> >
> > <li><a href="0050.html"><strong>RE: Mighty Orinoco ad</strong></a> <a
> > name="0050
> > "><em>Mark Eckell <small>(Mon Jan 27 2003 - 21:21:20 IST)</small></em></a>
> > </ul>
> >
> > This is different in the other index files: {date, author, subject}.html all
> > have a <a name="50"> anchors.
> >
> > The files do not display the version of hypermail used to generate them and I
> > should recify this. However, I generated them using the hypermail version I
> > installed, and hypermail -V gives me "hypermail: Version: 2.1.6 Patchlevel: 0".
> > I don't use a .hmrc file, but rather run
> >
> > hypermail -i -p -x -c $tmp.0
> >
> > where $tmp.0 consists of the isix lines
> >
> > hm_ihtmlheaderfile = $tmp.1
> > hm_ihtmlfooterfile = $tmp.2
> > hm_mhtmlheaderfile = $tmp.3
> > hm_mhtmlfooterfile = $tmp.4
> > hm_dir = $year/$month
> > hm_domainaddr = math.technion.ac.il
> >
> > and all the headers and footer files are dynamically generated.
> >
> > I apologize that I specified NAME in uppercase in my bug report, rather, then
> > name in lower case.
> >
> > On Mon, 27 Jan 2003 14:52:09 -0800, Peter C. McCluskey wrote about "Re: [hypermail] anchors don't have leading zero":
> > > rl_at_math.technion.ac.il (Zvi Har'El) writes:
> > > >Hi,
> > > >
> > > >I have noticed, using hypermail 2.1.6, that the hrefs to messages sorted by ...
> > > >in the footer of message page have anchors which are the message number, but
> > > >without the leading zeros. E.g, although the index page have anchors like
> > > ><A NAME="0030">, the message page has <A HREF="...#30">. I beleive the culprit
> > >
> > > I can't find any index pages with leading zeros in the anchors, nor can I
> > > find any anchors with an uppercase A NAME=. I see anchors with leading zeros
> > > in the thread_body*.html files produced by the files_by_thread option, but
> > > I don't see any faulty links to those anchors.
> > > Please tell us what ~/.hmrc you are using and give the name of a file in
> > > which you see the <A NAME="0030">. Also please verify that the bottom of
> > > the pages say "This archive was generated by hypermail 2.1.6" rather than
> > > some old version.
> > > --
> > > ------------------------------------------------------------------------------
> > > Peter McCluskey |
> > > http://www.rahul.net/pcm |
> >
> > --
> > Dr. Zvi Har'El mailto:rl_at_math.technion.ac.il Department of Mathematics
> > tel:+972-54-227607 icq:179294841 Technion - Israel Institute of Technology
> > fax:+972-4-8324654 http://www.math.technion.ac.il/~rl/ Haifa 32000, ISRAEL
> > "If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)
> > Tuesday, 25 Shevat 5763, 28 January 2003, 9:19AM
>
> --
> Dr. Zvi Har'El mailto:rl_at_math.technion.ac.il Department of Mathematics
> tel:+972-54-227607 icq:179294841 Technion - Israel Institute of Technology
> fax:+972-4-8324654 http://www.math.technion.ac.il/~rl/ Haifa 32000, ISRAEL
> "If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)
> Tuesday, 25 Shevat 5763, 28 January 2003, 11:12AM

-- 
Dr. Zvi Har'El     mailto:rl_at_math.technion.ac.il     Department of Mathematics
tel:+972-54-227607 icq:179294841     Technion - Israel Institute of Technology
fax:+972-4-8324654 http://www.math.technion.ac.il/~rl/     Haifa 32000, ISRAEL
"If you can't say somethin' nice, don't say nothin' at all." -- Thumper (1942)
                             Tuesday, 25 Shevat 5763, 28 January 2003, 11:30AM