Re: [hypermail] Serious message skipping problem with hypermail

From: kent landfield <kent_at_hypermail.org_at_hypermail-project.org>
Date: Thu, 5 Jun 2003 10:30:10 -0500 (CDT)
Message-Id: <20030605153010.F217B2701A2_at_dev.hypermail.org>


Jose Kahan writes:
> Proposed patches
> --------------
>
> 1. Fix the problem.
>
> if (set_increment) {
> int num_displayable;
> if (set_linkquotes)
> replylist = NULL;
> max_msgnum = -1;
>
> ^^^ just initialize it before calling loadoldheaders.
>
> 2. Add a backwards compatibility option, so that people who need to
> rebuild their archives can precise if they want them to start with 1 or
> 0.
>
> Something like:
>
> start_num_is_0
>
> And initialize max_msgnum accordingly (another patch is required when
> not using -u, to change max_msgnum accordingly. I tested it and it works
> ok too.)
>
> ----
>
> Any comments?
>
> In all cases, this is an awkward bug.
>
> -jose

I'm not sure it really matters if the starting number is 0001 or 0000. In the past it has been 0. Somewhere this bug creeped in then it was both. Maybe we could just go back to 0 and put a warning in the README. Seems like a waste of code to keep worrying about backwards compatibility for bugs.

-- 
Kent Landfield             |  HYPERMAIL: http://www.hypermail.org/ 
Email: kent_at_hypermail.org  |  RFCS: http://www.faqs.org/rfcs/
Received on Thu 05 Jun 2003 05:30:11 PM GMT

This archive was generated by hypermail 2.3.0 : Sat 13 Mar 2010 03:46:12 AM GMT GMT