Re: Bug in 2.0b2

From: Zvi Har'El <rl_at_math.technion.ac.il_at_hypermail-project.org>
Date: Fri, 11 Sep 1998 09:36:35 +0200 (IST)
Message-ID: <Pine.GSO.3.96.980911092410.24083A-100000_at_leeor.math.technion.ac.il>

On Fri, 11 Sep 1998, Daniel Stenberg wrote:

> The applied patch removes the "\n" from the "\nFrom " check for mail
> separation. The patch hopefully works for b3 and b2.

The patch works fine, and I thank you for it. However, it is not enough for people who use stuff from the archive subdirectory (I haven't had a chance to use it): The file mbox2hypermail.c needs patching as well, since it again checks for a null line, as the comment in line 221 says:

• If From and last line is a blank line we have
• found the message separator. Time to go to work.

I suggest to use the following patch:

• mbox2hypermail.c.orig Fri Aug 21 02:12:36 1998 --- mbox2hypermail.c Fri Sep 11 09:29:38 1998

  ---

• 216,226 **** if (first == 1) { /* First From in file ? */ first = 0; } ! else if (blankline(lastline)) { ! /* ! ** If From and last line is a blank line we have ! ** found the message separator. Time to go to work. ! */

                   fflush(msgfp);
                   fclose(msgfp);
--- 216,222 ----
               if (first == 1) {    /* First From in file ? */
                   first = 0;
               }
!              else {
  
                   fflush(msgfp);
                   fclose(msgfp);

I wish to stress the fact that I haven't had a chance to use the stuff in the archive subdirectory so I haven't really tested this patch, although it is trivial enough to see it does the work.

Best,

Zvi.

--
Dr. Zvi Har'El     mailto:rl_at_math.technion.ac.il     Department of Mathematics
+972-4-8294094(Phone)                Technion - Israel Institute of Technology
+972-4-8324654(FAX)  http://www.math.technion.ac.il/~rl/   Haifa 32000, ISRAEL
``If you can't say somethin' nice, don't say nothin' at all.''--Thumper (1942)

Received on Fri 11 Sep 1998 09:47:27 AM GMT