RE: base64 decoding bug

On Tue, 30 May 2000, Crispen, Bob wrote:

> > I think the nicest possible solution to this problem would be to add all
> > the
> > detected base64-lines to a linked list, and when the end of the section is
> > found we write a function that extends the current base64decoder and
> > decodes
> > all the lines in the list as one big base64-chunk.

> Why not good old recursion.

In what way would recursion help? And before you answer this, are you actually suggesting that we shall recurse on every base64-line? Last time I checked, there could be mails with 10MB+ attachments. That's a whole lot of lines. That's a whole lot of recursion...

> Perhaps I misunderstand the problem,

I think you do. Hypermail "generally" has no base64 problem, and having a look at your program I can't see anything in your source that looks like if you have addressed this problem. You are using about the same aproach as hypermail does now. And it isn't recursion. And it isn't 100% working.

Check out hypermail/src/parse.c, search for base64Decode().

> I believe what I've got there might solve the problem. At any rate, I
> haven't observer it to fail on unicode/quoted printable/etc. multi-line
> subject lines in my newsreader.

This has absolutely nothing to do with any mail headers. I'm talking about the mail body. I don't think hypermail has any problems with the headers.

Or am I wrong?

-- 
      Daniel Stenberg - http://daniel.haxx.nu - +46-705-44 31 77
   ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol