Re: [hypermail] hashed filenames patch commited to CVS

From: Peter C. McCluskey <pcm_at_rahul.net_at_hypermail-project.org>
Date: Mon, 30 Sep 2002 11:10:36 -0700 (PDT)
Message-Id: <20020930181036.362C282FF_at_yellow.rahul.net>

 jose.kahan_at_w3.org (Jose Kahan) writes:
>I'm using an 32 bit. FNV1 hash function [1] and giving it as input the
>msgid and the From date. This will hopefully allow to have a
>unique hash name. If the 2^32 hash space isn't wide enough, we can
>always move to 64 bits... time will tell.

 I'm not very happy with using hope as a means of avoiding problems. Is there a good reason for not detecting and fixing collisions?

>More in detail, the change was quite straightforward to do. I changed
>all the functions where a msgnum value was used to create lnks or make
>filenames and made it go through a function. In function of your
>hypermail options, this function (file.c:message_name()) will either
>return the msgnum formatted in %.04d or the message hash name.

 I still see a bunch of %.4d's in the source code, so I doubt you've been thorough.

-- 
------------------------------------------------------------------------------
Peter McCluskey          | Free Jon Johansen!
http://www.rahul.net/pcm | 

Received on Mon 30 Sep 2002 08:10:34 PM GMT